Bump to PHP 8.1 and add types everywhere #51
Merged
+71
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you should go ahead 👍 |
morozov
approved these changes
Oct 10, 2022
derrabus
force-pushed
the
improvement/types
branch
from
c349c72 to
b4d469e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PHP 8.1 will become the new minimum requirement for DBAL and ORM, I'd like to modernize the event manager to this language level as well.
This is a breaking change because of stricter parameter types and added native return types. If we agree to do this, I'd create a 2.0.x branch off 1.2.x and retarget this PR.