Merge pull request #815 from doctrine/fix-double-event

Fixed event that was firing twice when it should only fire once.
doctrine · Apr 25, 2019 · 43280c1 · 43280c1
2 parents 2d5c114 + c8ed964
commit 43280c1
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/lib/Doctrine/Migrations/Migrator.php b/lib/Doctrine/Migrations/Migrator.php
@@ -160,8 +160,6 @@ private function executeMigration(
     ) : array {
         $dryRun = $migratorConfiguration->isDryRun();
 
-        $this->configuration->dispatchMigrationEvent(Events::onMigrationsMigrating, $direction, $dryRun);
-
         $connection = $this->configuration->getConnection();
 
         $allOrNothing = $migratorConfiguration->isAllOrNothing();

diff --git a/tests/Doctrine/Migrations/Tests/Functional/FunctionalTest.php b/tests/Doctrine/Migrations/Tests/Functional/FunctionalTest.php
@@ -483,6 +483,7 @@ public function testSuccessfulMigrationDispatchesTheExpectedEvents() : void
             Events::onMigrationsVersionExecuting,
             Events::onMigrationsVersionExecuted,
         ] as $eventName) {
+            self::assertCount(1, $listener->events[$eventName]);
             self::assertArrayHasKey($eventName, $listener->events);
         }
     }