Merge pull request #1197 from BafS/patch-1

Fix "transactional" configuration
doctrine · Sep 16, 2021 · 51e4703 · 51e4703
2 parents 818e317 + f916614
commit 51e4703
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/Doctrine/Migrations/Configuration/Migration/ConfigurationArray.php b/lib/Doctrine/Migrations/Configuration/Migration/ConfigurationArray.php
@@ -62,7 +62,7 @@ public function getConfiguration(): Configuration
                 $configuration->setAllOrNothing(is_bool($value) ? $value : BooleanStringFormatter::toBoolean($value, false));
             },
             'transactional' => static function ($value, Configuration $configuration): void {
-                $configuration->setAllOrNothing(is_bool($value) ? $value : BooleanStringFormatter::toBoolean($value, true));
+                $configuration->setTransactional(is_bool($value) ? $value : BooleanStringFormatter::toBoolean($value, true));
             },
             'check_database_platform' =>  static function ($value, Configuration $configuration): void {
                 $configuration->setCheckDatabasePlatform(is_bool($value) ? $value : BooleanStringFormatter::toBoolean($value, false));

diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -11,7 +11,7 @@ parameters:
             message: '~^Call to function in_array\(\) requires parameter #3 to be true\.$~'
             path: %currentWorkingDirectory%/lib/Doctrine/Migrations/Version/SortedMigrationPlanCalculator.php
         -
-            message: '~^Variable property access on mixed\.$~'
+            message: '~^Variable property access on SimpleXMLElement\.$~'
             path: %currentWorkingDirectory%/lib/Doctrine/Migrations/Configuration/Migration/XmlFile.php
         -
             message: '~^Call to function is_bool\(\) with bool will always evaluate to true\.$~'