Merge pull request #953 from goetas/execute-update-call

Remove superfluous parameters check on executeUpdate
doctrine · Mar 28, 2020 · ed5b127 · ed5b127
2 parents 96a6832 + f0f1001
commit ed5b127
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/lib/Doctrine/Migrations/Version/DbalExecutor.php b/lib/Doctrine/Migrations/Version/DbalExecutor.php
@@ -291,16 +291,10 @@ private function logResult(Throwable $e, ExecutionResult $result, MigrationPlan
     private function executeResult(MigratorConfiguration $configuration) : void
     {
         foreach ($this->sql as $key => $query) {
-            $stopwatchEvent = $this->stopwatch->start('query');
-
             $this->outputSqlQuery($query);
 
-            if (count($query->getParameters()) === 0) {
-                $this->connection->executeUpdate($query->getStatement());
-            } else {
-                $this->connection->executeUpdate($query->getStatement(), $query->getParameters(), $query->getTypes());
-            }
-
+            $stopwatchEvent = $this->stopwatch->start('query');
+            $this->connection->executeUpdate($query->getStatement(), $query->getParameters(), $query->getTypes());
             $stopwatchEvent->stop();
 
             if (! $configuration->getTimeAllQueries()) {