Allow version aliases to be used with execute command #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Padam87
force-pushed
the
execute_version_aliases
branch
from
f2c0394
to
5b0b076
Compare
goetas
reviewed
Aug 22, 2021
| 'The versions to execute.', | ||
| sprintf( | ||
| 'The versions to execute. Use the FQCN of the migration, or the following reserved aliases: %s', | ||
| implode(', ', ['first', 'current', 'prev', 'next', 'latest']) |
There was a problem hiding this comment.
does it make sense to get this list from the interface somehow?
There was a problem hiding this comment.
A getSupportedAliases method would be easy to impletement, but using it could be trouble, because of the verbatim return, and the current-1 formats.
Should I go for it? If so, should it be enforced with a supports method, or just a simple listing?
|
Since this is a new feature, ive changed the base branch to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR plugs in the alias resolver to the execute command in order to simplify executing a migration.
In practice, this would improve DX, because the last migration could be easily
--down-ed, when spotting a mistake.