Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove migration table from generated comparison schema #1418

Open
wants to merge 4 commits into
base: 3.7.x
Choose a base branch
from

Conversation

wmouwen
Copy link

@wmouwen wmouwen commented Mar 17, 2024

Q A
Type bug
BC Break no
Fixed issues #1406

Summary

doctrine/orm#11374

Schemas generated from metadata cause the event ToolEvents::postGenerateSchema to be triggered in the method SchemaTool::getSchemaFromMetadata. It would be helpful to do the same for schemas generated for comparison in SchemaTool::createSchemaForComparison. This PR introduces the new event ToolEvents::postGenerateComparisonSchema.

This new event, given that the PR in doctrine/orm proceeds, can be utilized in a listener to remove the metadata table from the comparison schema.

PR relates to an attempt to fix #1406. It requires doctrine/orm#11374 and is a requirement of doctrine/DoctrineMigrationsBundle#529.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doctrine:schema:validate returns DROP TABLE doctrine_migration_versions;
1 participant