Support new aggregation operators in builder #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
new-aggregation-operators
branch
2 times, most recently
from
6e1575f
to
75ab4da
Compare
jmikola
reviewed
Mar 23, 2023
lib/Doctrine/ODM/MongoDB/Aggregation/Operator/ArrayOperators.php
Outdated
Show resolved
Hide resolved
jmikola
reviewed
Mar 24, 2023
tests/Doctrine/ODM/MongoDB/Tests/Aggregation/Stage/BucketAutoTest.php
Outdated
Show resolved
Hide resolved
|
Note: test failures on PHP 7.4 are due to |
jmikola
reviewed
Mar 24, 2023
lib/Doctrine/ODM/MongoDB/Aggregation/Operator/CustomOperators.php
Outdated
Show resolved
Hide resolved
jmikola
approved these changes
Mar 24, 2023
alcaeus
force-pushed
the
new-aggregation-operators
branch
from
db72b9c
to
99f1ece
Compare
Note: ProvidesGroupAccumulatorOperators errors were ignored as the trait is designed to be used in conjunction with the corresponding interface.
alcaeus
force-pushed
the
new-aggregation-operators
branch
from
99f1ece
to
9e62307
Compare
alcaeus
force-pushed
the
new-aggregation-operators
branch
from
9e62307
to
b6d1fc5
Compare
|
Ignoring PHPStan as those failures are the same we're already seeing due to psalm types. |
notrix
pushed a commit
to notrix/mongodb-odm
that referenced
this pull request
Apr 6, 2023
* Add interfaces for aggregation pipeline operators * Implement new aggregation pipeline operators in stages * Update static analysis baselines * Use consistent formatting for operators with optional arguments * Use consistent capitalisation for "date object" * Wrap docblock comments * Rename ensureArray to something more descriptive * Remove duplicated docblocks * Use func_get_args when proxying expression methods * Fix wrong return types for internal expr methods * Use func_get_args for operators where possible * Disambiguate closure param in tests * Fix docblock errors Note: ProvidesGroupAccumulatorOperators errors were ignored as the trait is designed to be used in conjunction with the corresponding interface. * Make initArgs parameter for $accumulator optional * Use static return types across aggregation builder * Fix handling of optional parameters for $range and $slice
alcaeus
added a commit
that referenced
this pull request
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the following new aggregation pipeline operators to the builder:
$accumulator,$binarySize,$bottom,$bottomN,$bsonSize,$dateAdd,$dateDiff,$dateFromParts,$dateFromString,$dateSubtract,$dateToParts,$dateTrunc,$firstN,$function,$getField,$lastsN,$maxN,$mergeObjects,$minN,$rand,$regexFind,$regexFindAll,$regexMatch,$replaceAll,$replaceOne,$sampleRate,$setField,$sortArray,$top,$topN,$tsIncrement,$tsSecond.This covers all aggregation pipeline operators currently supported in MongoDB, with the exception of accumulator operators only supported in the
$setWindowFieldsstage, which will be introduced in a separate pull request.I've also taken liberty to organise the code a bit. We now have interfaces for the various operator groups instead of one generic operator interface, and I've cleaned up the logic around accumulator stages (such as
$sum) which have two different forms depending on the stage they're being used in. In the$group,$bucket, and$bucketAutostages they take a single argument, whereas they take multiple arguments in other stages such as$project. This is now properly accounted for and easier to handle due to a trait that handles this more gracefully.Note: GitHub Copilot was instrumental in getting this work done as it automated away certain repetitive tasks (such as adding proxy methods to the
Operatorclass. I've also marked that class as@internalas we may want to do away with it in the future in favour of multiple traits that add specific operator groups, similar to how we have interfaces for the groups.