Fix phpstan errors #2593
Merged
Fix phpstan errors #2593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've changed to use I'll try to fix it in phpstan following phpstan/phpstan#10192 (comment) |
malarzm
approved these changes
Dec 17, 2023
|
Thanks @franmomu for finishing this! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes one error where the
enumTypemapping field gets rewritten to theclass-string<UnitEnum>type because we don't ensure that the enum is backed before re-assigningenumType. The other issue inmapFieldis less obvious and I can't figure out where it takes theclass-string<UnitEnum>type from, so I decided to ignore that for the time being. These issues started appearing with the latest phpstan release.