Fix criteria mapping type

[franmomu]

Q	A
Type	bug
BC Break	no
Fixed issues

Summary

While doing #2596, the SA tool complained about the type of this property. For example in

mongodb-odm/tests/Documents/BlogPost.php

Line 63 in a51bfc0

* @ODM\ReferenceMany(targetDocument=Comment::class, mappedBy="parent", criteria={"isByAdmin"=true}, sort={"date"="desc"})

$criteria is holding an array that contains a boolean.

It is used in

mongodb-odm/lib/Doctrine/ODM/MongoDB/Persisters/DocumentPersister.php

Lines 762 to 767 in a51bfc0

	$criteria = $this->cm->merge(
	['_id' => ['$in' => array_values($ids)]],
	$this->dm->getFilterCollection()->getFilterCriteria($class),
	$mapping['criteria'] ?? [],
	);
	$criteria = $this->uow->getDocumentPersister($className)->prepareQueryOrNewObj($criteria);

and

mongodb-odm/lib/Doctrine/ODM/MongoDB/Persisters/DocumentPersister.php

Lines 830 to 834 in a51bfc0

	$criteria = $this->cm->merge(
	[$mappedByFieldName => $ownerClass->getIdentifierObject($owner)],
	$this->dm->getFilterCollection()->getFilterCriteria($targetClass),
	$mapping['criteria'] ?? [],
	);

so it looks like it could contain any type, not only strings.

Ref: https://github.com/doctrine/mongodb-odm/pull/2596/files#r1441864943

[malarzm]

Good catch! There's new PHPStan complaint tho :D

[franmomu]

Good catch! There's new PHPStan complaint tho :D

I've ignored the complaint since it has been reported in vimeo/psalm#10578