Fix entity refresh after cleared em #10362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonberger
commented
Jan 3, 2023
|
|
||
| * @psalm-return array<string, true> | ||
| */ | ||
| private function collectClassSkippedProperties( |
There was a problem hiding this comment.
Straight forward solution coming into my mind first but really not the most elegant one. A pity the already available field mapping of ClassMetadataInfo cannot be used. It just misses a few information like private visibility of the properties.
Another much easier fix could be to make sure the identifier is in the skip array after the loop. If this is not the case we should be able to consider it private and therefor have all information to add it. All other private properties of parent classes should not matter anyway, if I got that correctly.
This was referenced Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10336
Includes reproducing test of #10337
This fixes a missing handling of HINT_REFRESH_ENTITY and ignored private identifier property in a parent class.