Fix psalm errors: remove override of template type #11389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Recreation of PR #11385 onto proper target branch |
tantegerda1
force-pushed
the
2.19.x
branch
3 times, most recently
from
50bf6f0
to
00952f9
Compare
|
Psalm is failing. |
See doctrine/collections#368 for the same issue in doctrine/collections which has been fixed there. The issue happens when using ->contains(). Running psalm emits > InvalidArgument - Argument 1 of Doctrine\ORM\PersistentCollection::contains > expects > TMaybeContained:fn-doctrine\common\collections\readablecollection::contains > as mixed, but … provided. Solution: we should either not define @template TMaybeContained or re-define the complete psalm docblock from ReadableCollection. Repairing the docblock necessitates an update to the psalm baseline: one "known issue" is no longer an issue and thus removed.
greg0ire
approved these changes
Mar 23, 2024
|
Thanks @tantegerda1 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See doctrine/collections#368 for the same issue in doctrine/collections which has been fixed there.
The issue happened when using ->contains(). Running psalm emitted
We should either not define @template TMaybeContained or re-define the psalm docblock from ReadableCollection completely.
Repairing the docblock necessitates an update to the psalm baseline: one "known issue" is no longer an issue and could thus be removed.