Add Proxy::__setInitialized() and RuntimeReflectionProperty #307
+379
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
proxy-set-init
branch
2 times, most recently
from
439c730 to
a719963
Compare
greg0ire
previously approved these changes
Oct 3, 2022
beberlei
reviewed
Oct 3, 2022
nicolas-grekas
force-pushed
the
proxy-set-init
branch
2 times, most recently
from
407c179 to
3bceb4e
Compare
stof
reviewed
Oct 7, 2022
nicolas-grekas
force-pushed
the
proxy-set-init
branch
from
3bceb4e to
c6e1468
Compare
greg0ire
approved these changes
Oct 8, 2022
derrabus
approved these changes
Oct 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the path to deprecate
Doctrine\Common\Proxy\Proxy, I figured out that we're going to need adding__setInitialized()to theProxyinterface. This is because we need it inRuntimeReflectionPropertyto disable lazy-loading while callingReflectionProperty::setValue().The new
RuntimeReflectionPropertyallows getting+setting any properties on objects while preventing lazy-loading initialization, which is something that's going to be needed also to move to more capable proxy implementations.RuntimePublicReflectionPropertyis not enough and is thus deprecated.