-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade git-url-parse to 13.1.0 #1565
Conversation
Fixes: documentationjs#1558 Signed-off-by: Lance Ball <lball@redhat.com>
Hi, will you backport this dep upgrade to v13? |
@paoliniluis sure but I don't see a |
sorry, I thought there was. I'm afraid that this needs to be handled by one of the core maintainers if they want to backport this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this.
I won't have the time to backport this - there were a ton of dependency updates for version 14, including node 18 compatibility (LTS from tomorrow), so if it in any way is possible to upgrade to documentation.js v14 that would be my recommendation, or maybe i can help with migration issues.
Thanks! Do you have any idea when there will be a new release with the dependency bump that was just merged? |
We are already using |
Sorry @birkskyum - just realized your comment was directed at @paoliniluis ... |
Can this please be released? |
@birkskyum is there anything holding back a 14.0.1 release that includes just this one fix? It would fix the AFAICT, this is the only commit since the 14.0.0 tag. |
@marques-work , @rotu, @paoliniluis it's released now. |
Thanks so much! |
Fixes: #1558
Signed-off-by: Lance Ball lball@redhat.com