Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FreeBSD support #3956

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add FreeBSD support #3956

wants to merge 1 commit into from

Conversation

er2off
Copy link

@er2off er2off commented Apr 13, 2024

This pull request adds initial FreeBSD operating system support.

To build: env CC=cc CXX=c++ ./package_native.sh <other args here> --64-only (for 64-bit system)
(gcc13 is currently not working)

meson.build Outdated Show resolved Hide resolved
@@ -41,6 +43,12 @@ while [ $# -gt 0 ]; do
"--build-id")
opt_buildid=true
;;
"--64-only")
opt_64_only=1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Author

@er2off er2off Apr 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To build 64-bit only version of library of course. If build 32 bit version too, library can be built but can't be linked with SDL because FreeBSD package manager can install only 64 or 32 bit software, in this case we need to build SDL2 for x86 from source code.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use dependency(...) then for Linux/BSD paths.

I am okay with not caring about 32-bit BSDs, it's 2024.

@flibitijibibo
Copy link
Contributor

Just did a fresh rebase of #3834, does rebasing this on top of those changes help make the meson changes unnecessary?

@er2off
Copy link
Author

er2off commented May 12, 2024

does rebasing this on top of those changes help make the meson changes unnecessary?

@flibitijibibo yes, it works perfect. Also gcc build is workable if add limits.h include to src/util/util_env.cpp (why it worked with clang without this include?)

@flibitijibibo
Copy link
Contributor

The relevant meson changes were merged, so this should be able to rebase without the meson.build changes and work as intended!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants