New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FreeBSD support #3956
base: master
Are you sure you want to change the base?
Add FreeBSD support #3956
Conversation
@@ -41,6 +43,12 @@ while [ $# -gt 0 ]; do | |||
"--build-id") | |||
opt_buildid=true | |||
;; | |||
"--64-only") | |||
opt_64_only=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To build 64-bit only version of library of course. If build 32 bit version too, library can be built but can't be linked with SDL because FreeBSD package manager can install only 64 or 32 bit software, in this case we need to build SDL2 for x86 from source code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use dependency(...) then for Linux/BSD paths.
I am okay with not caring about 32-bit BSDs, it's 2024.
Just did a fresh rebase of #3834, does rebasing this on top of those changes help make the meson changes unnecessary? |
@flibitijibibo yes, it works perfect. Also gcc build is workable if add limits.h include to src/util/util_env.cpp (why it worked with clang without this include?) |
The relevant meson changes were merged, so this should be able to rebase without the meson.build changes and work as intended! |
This pull request adds initial FreeBSD operating system support.
To build:
env CC=cc CXX=c++ ./package_native.sh <other args here> --64-only
(for 64-bit system)(gcc13 is currently not working)