[d3d9] Validate DS format support during CheckDepthStencilMatch #3982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified with #3938 |
|
P.S.: The game in question reverts to using D3DFMT_D24X8 if the initial call to CheckDepthStencilMatch() with D3DFMT_D32 fails. This is apparent in the trace captured with WineD3D. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3938. Adds a check against passed DS formats during calls to
CheckDepthStencilMatch(). Should prevent games from using D32, D15S1 and D24X4S4 going forward.We had to do a similar check for DS formats in d8vk for what it's worth, so this makes sense.