Upgrade webpack v4 #213
Merged
Upgrade webpack v4 #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-gadd
reviewed
Nov 21, 2018
package.json
Outdated
| "webpack-dev-middleware": "3.4.0", | ||
| "webpack-hot-middleware": "2.24.3", | ||
| "webpack-manifest-plugin": "2.0.4", | ||
| "webpack-mild-compile": "2.0.0", |
There was a problem hiding this comment.
this needs to be in 3.0.0 range otherwise webpack complains with a deprecation warning
There was a problem hiding this comment.
3.3.1 was just released last night, which is the first v3 version that doesn't crash or hang for all eternity. I'll push that change in a bit.
mwistrand
force-pushed
the
upgrade-webpack-v4
branch
from
1ee4c72
to
0c0a1ed
Compare
- Temporarily add local, upgraded `@dojo/webpack-contrib` - Temporarily update package.json for CI - Replace ExtractTextPlugin with MiniCssExtractPlugin, but pin to 0.4.2 until shellscape/webpack-manifest-plugin#167 is resolved - Replace removed CommonsChunkPlugin with `optimize.splitChunks` configuration option - Remove plugins provided by `mode` configuration option: NamedChunksPlugin, NamedModulesPlugin, and DefinePlugin - Use terser-webpack-plugin over uglifyjs-webpack-plugin-terser - Upgrade to webpack-mild-compile@3.3.1 - Add runtime chunk, disable default chunk, and force modules into main chunk - Filter css order warnings - Move optimize-css-assets-webpack-plugin to dist config - Update tapable typings
mwistrand
force-pushed
the
upgrade-webpack-v4
branch
from
15682f0
to
8662cac
Compare
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
==========================================
- Coverage 54.2% 53.93% -0.28%
==========================================
Files 10 10
Lines 594 597 +3
Branches 145 144 -1
==========================================
Hits 322 322
- Misses 272 275 +3
Continue to review full report at Codecov.
|
agubler
reviewed
Nov 30, 2018
package.json
Outdated
| "postcss-preset-env": "5.3.0", | ||
| "slash": "1.0.0", | ||
| "source-map-loader-cli": "0.0.1", | ||
| "strip-ansi": "3.0.1", | ||
| "style-loader": "0.19.0", | ||
| "ts-loader": "3.1.1", | ||
| "terser-webpack-plugin": "^1.1.0", |
There was a problem hiding this comment.
Thanks for catching that.
agubler
approved these changes
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettierDescription:
Blocked by dojo/webpack-contrib#93 and should not be merged until
package.jsonis updated with the nextwebpack-contribrelease. Verified on both macOS and Windows with multiple test applications.optimize.splitChunksconfiguration optionmodeconfiguration option: NamedChunksPlugin, NamedModulesPlugin, and DefinePluginResolves #68