Remove fixtures and use Cypress for integration tests #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
==========================================
+ Coverage 69.83% 69.91% +0.08%
==========================================
Files 8 8
Lines 358 359 +1
Branches 62 62
==========================================
+ Hits 250 251 +1
Misses 108 108
Continue to review full report at Codecov.
|
|
@mwistrand looks like you have a failure on appveyor |
agubler
approved these changes
Jan 8, 2019
- Remove the fixtures and update the functional tests use Cypress - Update the test-app build to copy an index.html file that loads the build custom elements - Clean up the gitignore - Add integration tests for the --legacy flag - Improve `features` logic
agubler
reviewed
Jan 22, 2019
src/base.config.ts
Outdated
| @@ -88,7 +89,7 @@ export default function webpackConfigFactory(args: any): webpack.Configuration { | |||
| const jsonpIdent = args.element ? args.element.name : 'custom-elements'; | |||
| const extensions = args.legacy ? ['.ts', '.tsx', '.js'] : ['.ts', '.tsx', '.mjs', '.js']; | |||
| const compilerOptions = args.legacy ? {} : { target: 'es6', module: 'esnext' }; | |||
| const features = args.legacy ? args.features : ['chrome']; | |||
| const features = args.legacy ? args.features : { ...(args.features || {}), ...getFeatures('chrome') }; | |||
There was a problem hiding this comment.
Ah this is actually modern now, missed updating this when I updated webpack-contrib
There was a problem hiding this comment.
Easily done here. Once CI passes I'll merge. Thanks!
agubler
approved these changes
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.gitignore--legacyflagfeatureslogicResolves #46