Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of FileResult's with content types #2841

Merged
merged 5 commits into from
Apr 29, 2024
Merged

Fix handling of FileResult's with content types #2841

merged 5 commits into from
Apr 29, 2024

Commits on Apr 26, 2024

  1. Fix handling of FileResult's with content types 

    When ProducesResponseType is used with FileResult subclasses and explicit content types, ApiExplorer sets ModelMetadata to null. We were then erroneously treating it as returning no content.
Resolves domaindrivendev#2320, domaindrivendev#2386
    @IGx89
    IGx89 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    df20949 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Update test/Swashbuckle.AspNetCore.SwaggerGen.Test/SwaggerGenerator/S… 

    …waggerGeneratorTests.cs

Co-authored-by: Martin Costello <martin@martincostello.com>
    @IGx89 @martincostello
    IGx89 and martincostello committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    ff10c3b View commit details
    Browse the repository at this point in the history

  2. Change return type back to abstract parent class

    @IGx89
    IGx89 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    d6ccc59 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into domaindrivendevgh-2320-contenttype-with-fi… 

    …leresult
    @IGx89
    IGx89 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    dc1521c View commit details
    Browse the repository at this point in the history

  4. Fix merge issue

    @IGx89
    IGx89 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    7cd9f38 View commit details
    Browse the repository at this point in the history