fix(esbuild): update to tsconfck 3.0.1 to fix edge cases when resolvi…

…ng tsconfig.extends
dominikg · Jan 3, 2024 · 7d30d32 · 7d30d32
1 parent d2aa096
commit 7d30d32
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 13 deletions.
diff --git a/packages/vite/package.json b/packages/vite/package.json
@@ -135,7 +135,7 @@
     "source-map-support": "^0.5.21",
     "strip-ansi": "^7.1.0",
     "strip-literal": "^2.0.0",
-    "tsconfck": "^3.0.0",
+    "tsconfck": "^3.0.1",
     "tslib": "^2.6.2",
     "types": "link:./types",
     "ufo": "^1.3.2",

diff --git a/packages/vite/src/node/plugins/esbuild.ts b/packages/vite/src/node/plugins/esbuild.ts
@@ -444,14 +444,7 @@ async function loadTsconfigJsonForFile(
   filename: string,
 ): Promise<TSConfigJSON> {
   try {
-    if (tsconfckCache) {
-      // shortcut, the cache stores resolved TSConfckParseResult
-      // so getting it from the cache directly we bypass async fn call wrapping it in a promise again
-      if (tsconfckCache.hasParseResult(filename)) {
-        const result = await tsconfckCache.getParseResult(filename)
-        return result.tsconfig
-      }
-    } else {
+    if (!tsconfckCache) {
       tsconfckCache = new TSConfckCache<TSConfckParseResult>()
     }
     const result = await parse(filename, {

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml