Skip to content

Commit

Permalink
fix: remove broken executable "resolver" for arm64 arch
Browse files Browse the repository at this point in the history
Same as puppeteer#6914 but with a different commit message.

With this change, we don't need to patch puppeteer on M1. See puppeteer#6622.
  • Loading branch information
domoritz committed Mar 22, 2021
1 parent dc8ab6d commit ecd91b7
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions src/node/Launcher.ts
Expand Up @@ -105,13 +105,9 @@ class ChromeLauncher implements ProductLauncher {

let chromeExecutable = executablePath;
if (!executablePath) {
if (os.arch() === 'arm64') {
chromeExecutable = '/usr/bin/chromium-browser';
} else {
const { missingText, executablePath } = resolveExecutablePath(this);
if (missingText) throw new Error(missingText);
chromeExecutable = executablePath;
}
const { missingText, executablePath } = resolveExecutablePath(this);
if (missingText) throw new Error(missingText);
chromeExecutable = executablePath;
}

const usePipe = chromeArguments.includes('--remote-debugging-pipe');
Expand Down

0 comments on commit ecd91b7

Please sign in to comment.