Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't overwrite M-/ in web-mode #7866

Closed
wants to merge 1 commit into from
Closed

Don't overwrite M-/ in web-mode #7866

wants to merge 1 commit into from

Conversation

kuba-orlik
Copy link
Contributor

@kuba-orlik kuba-orlik commented May 18, 2024 •
edited

The M-/ is a default shortcut for dabbrev-expand, and having one mode where it does something else is confusing. I propose to remove this custom binding and use the default M-; that's used for comment/uncomment in most other mode

  • I searched the issue tracker and this hasn't been PRed before.
  • My changes are not on the do-not-PR list for this project.
  • My commits conform to the git conventions.
  • My changes are visual; I've included before and after screenshots.
  • I am blindly checking these off.
  • Any relevant issues or PRs have been linked to.
  • This a draft PR; I need more time to finish it.

@kuba-orlik
tweak(:lang): Don't overwrite M-/ in web-mode
fa5dd65 
The M-/ is a default shortcut for dabbrev-expand, and having one mode where it does something else is confusing. I propose to remove this custom binding and use the default M-; that's used for comment/uncomment  in most other modes

* modules/lang/web/+html.el - change the binding
@hlissner hlissner added re:keybinds Changes to or discussion about Doom's keybinds is:tweak Code changes that affects user-facing behavior module:lang/web Pertains to Doom's :lang web module was:moved Is, was, or will be addressed elsewhere labels Jun 3, 2024
@hlissner hlissner added this to the modules v24.06 milestone Jun 3, 2024
@hlissner hlissner closed this in b4531dd Jun 3, 2024
@hlissner
Copy link
Member

hlissner commented Jun 3, 2024

There was already a keybind for M-; on web-mode-map, so the rebinding wasn't needed. I've adjusted and merged this into b4531dd (and to correct the scope in the git commit message), so this can be considered resolved. Thanks for bringing it to my attention, in any case!

LemonBreezes pushed a commit to LemonBreezes/doomemacs that referenced this pull request Jun 3, 2024
@hlissner @kuba-orlik @LemonBreezes
tweak(web): remove M-/ keybind
9610a5a 
As brought up in doomemacs#7866, M-/ is bound to dabbrev-expand by default. Also,
a `M-;` keybind already exists on web-mode-map for commenting (and is
the vanilla default for commenting in other modes), so I'm removing this
redundant keybind.

Close: doomemacs#7866
Co-authored-by: kuba-orlik <kuba-orlik@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
is:tweak Code changes that affects user-facing behavior module:lang/web Pertains to Doom's :lang web module re:keybinds Changes to or discussion about Doom's keybinds was:moved Is, was, or will be addressed elsewhere
Projects
None yet
Milestone
modules v24.06
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kuba-orlik @hlissner