fix: reporting wrong number of tests in Dart #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any chance this gets reviewed anytime soon, @jozefizso? |
|
Hi @dominicmh, thanks for notifying me. I reviewed the code and it looks good! |
jozefizso
added
bug
artemrys
pushed a commit
to splunk/addonfactory-workflow-addon-release
that referenced
this pull request
May 17, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/cache](https://togithub.com/actions/cache) | action | major | `v3` -> `v4` | | [actions/checkout](https://togithub.com/actions/checkout) | action | major | `v3` -> `v4` | | [actions/download-artifact](https://togithub.com/actions/download-artifact) | action | major | `v3` -> `v4` | | [actions/upload-artifact](https://togithub.com/actions/upload-artifact) | action | major | `v3` -> `v4` | | [amannn/action-semantic-pull-request](https://togithub.com/amannn/action-semantic-pull-request) | action | minor | `v5.4.0` -> `v5.5.2` | | [aws-actions/configure-aws-credentials](https://togithub.com/aws-actions/configure-aws-credentials) | action | major | `v3` -> `v4` | | [dorny/test-reporter](https://togithub.com/dorny/test-reporter) | action | minor | `v1.7.0` -> `v1.9.1` | | ghcr.io/splunk/workflow-engine-base | container | major | `2.0.12` -> `3.0.0` | --- ### Release Notes <details> <summary>actions/cache (actions/cache)</summary> ### [`v4`](https://togithub.com/actions/cache/compare/v3...v4) [Compare Source](https://togithub.com/actions/cache/compare/v3...v4) </details> <details> <summary>actions/checkout (actions/checkout)</summary> ### [`v4`](https://togithub.com/actions/checkout/blob/HEAD/CHANGELOG.md#v400) [Compare Source](https://togithub.com/actions/checkout/compare/v3...v4) - [Support fetching without the --progress option](https://togithub.com/actions/checkout/pull/1067) - [Update to node20](https://togithub.com/actions/checkout/pull/1436) </details> <details> <summary>actions/download-artifact (actions/download-artifact)</summary> ### [`v4`](https://togithub.com/actions/download-artifact/compare/v3...v4) [Compare Source](https://togithub.com/actions/download-artifact/compare/v3...v4) </details> <details> <summary>actions/upload-artifact (actions/upload-artifact)</summary> ### [`v4`](https://togithub.com/actions/upload-artifact/compare/v3...v4) [Compare Source](https://togithub.com/actions/upload-artifact/compare/v3...v4) </details> <details> <summary>amannn/action-semantic-pull-request (amannn/action-semantic-pull-request)</summary> ### [`v5.5.2`](https://togithub.com/amannn/action-semantic-pull-request/releases/tag/v5.5.2) [Compare Source](https://togithub.com/amannn/action-semantic-pull-request/compare/v5.5.1...v5.5.2) ##### Bug Fixes - Bump tar from 6.1.11 to 6.2.1 ([#​262](https://togithub.com/amannn/action-semantic-pull-request/issues/262) by [@​EelcoLos](https://togithub.com/EelcoLos)) ([9a90d5a](https://togithub.com/amannn/action-semantic-pull-request/commit/9a90d5a5ac979326e3bb9272750cdd4f192ce24a)) ### [`v5.5.1`](https://togithub.com/amannn/action-semantic-pull-request/releases/tag/v5.5.1) [Compare Source](https://togithub.com/amannn/action-semantic-pull-request/compare/v5.5.0...v5.5.1) ##### Bug Fixes - Bump ip from 2.0.0 to 2.0.1 ([#​263](https://togithub.com/amannn/action-semantic-pull-request/issues/263) by [@​EelcoLos](https://togithub.com/EelcoLos)) ([5e7e9ac](https://togithub.com/amannn/action-semantic-pull-request/commit/5e7e9acca3ddc6a9d7b640fe1f905c4fff131f4a)) ### [`v5.5.0`](https://togithub.com/amannn/action-semantic-pull-request/releases/tag/v5.5.0) [Compare Source](https://togithub.com/amannn/action-semantic-pull-request/compare/v5.4.0...v5.5.0) ##### Features - Add outputs for `type`, `scope` and `subject` ([#​261](https://togithub.com/amannn/action-semantic-pull-request/issues/261) by [@​bcaurel](https://togithub.com/bcaurel)) ([b05f5f6](https://togithub.com/amannn/action-semantic-pull-request/commit/b05f5f6423ef5cdfc7fdff00c4c10dd9a4f54aff)) </details> <details> <summary>aws-actions/configure-aws-credentials (aws-actions/configure-aws-credentials)</summary> ### [`v4`](https://togithub.com/aws-actions/configure-aws-credentials/releases/tag/v4) [Compare Source](https://togithub.com/aws-actions/configure-aws-credentials/compare/v3...v4) This tag tracks the latest v4.x.x release </details> <details> <summary>dorny/test-reporter (dorny/test-reporter)</summary> ### [`v1.9.1`](https://togithub.com/dorny/test-reporter/releases/tag/v1.9.1) [Compare Source](https://togithub.com/dorny/test-reporter/compare/v1.9.0...v1.9.1) #### What's Changed - fix: reporting wrong number of tests in Dart by [@​dominicmh](https://togithub.com/dominicmh) in [dorny/test-reporter#426 - Fix problematic retransmission of authentication token (alternative solution) by [@​JojOatXGME](https://togithub.com/JojOatXGME) in [dorny/test-reporter#438 - Update development dependencies by [@​jozefizso](https://togithub.com/jozefizso) in [dorny/test-reporter#442 #### New Contributors - [@​dominicmh](https://togithub.com/dominicmh) made their first contribution in [dorny/test-reporter#426 - [@​JojOatXGME](https://togithub.com/JojOatXGME) made their first contribution in [dorny/test-reporter#438 **Full Changelog**: dorny/test-reporter@v1.9.0...v1.9.1 ### [`v1.9.0`](https://togithub.com/dorny/test-reporter/releases/tag/v1.9.0) [Compare Source](https://togithub.com/dorny/test-reporter/compare/v1.8.0...v1.9.0) #### What's Changed ##### Features - Add support for the `rspec-json` format [#​398](https://togithub.com/dorny/test-reporter/issues/398) - Updated packages [#​405](https://togithub.com/dorny/test-reporter/issues/405) #### Contributors - [@​oscarmampel](https://togithub.com/oscarmampel) made their contribution in [#​398](https://togithub.com/dorny/test-reporter/issues/398) **Full Changelog**: dorny/test-reporter@v1.8.0...v1.9.0 ### [`v1.8.0`](https://togithub.com/dorny/test-reporter/releases/tag/v1.8.0) [Compare Source](https://togithub.com/dorny/test-reporter/compare/v1.7.0...v1.8.0) ##### What's Changed - CHANGELOG.md by [@​j-catania](https://togithub.com/j-catania) in [dorny/test-reporter#297 - Bump [@​babel/traverse](https://togithub.com/babel/traverse) from 7.12.1 to 7.23.2 in /reports/jest by [@​dependabot](https://togithub.com/dependabot) in [dorny/test-reporter#303 - Bump [@​babel/traverse](https://togithub.com/babel/traverse) from 7.22.20 to 7.23.2 by [@​dependabot](https://togithub.com/dependabot) in [dorny/test-reporter#304 - Add `SwiftXunitParser` class based on `JavaJunitParser` for `swift-xunit` reporter by [@​jozefizso](https://togithub.com/jozefizso) in [dorny/test-reporter#317 - Update to Node20 by [@​j-catania](https://togithub.com/j-catania) in [dorny/test-reporter#315 - Fix build error by [@​dorny](https://togithub.com/dorny) in [dorny/test-reporter#331 - Use NodeJS 18 LTS as default runtime by [@​jozefizso](https://togithub.com/jozefizso) in [dorny/test-reporter#332 - Update all packages by [@​jozefizso](https://togithub.com/jozefizso) in [dorny/test-reporter#333 - Escape <> characters in suite name by [@​wingyplus](https://togithub.com/wingyplus) in [dorny/test-reporter#236 - Adding feature and bug template by [@​j-catania](https://togithub.com/j-catania) in [dorny/test-reporter#341 - Update check title and remove icon by [@​ldaneliukas](https://togithub.com/ldaneliukas) in [dorny/test-reporter#144 - `test-reporter` release v1.8.0 by [@​jozefizso](https://togithub.com/jozefizso) in [dorny/test-reporter#370 ##### New Contributors - [@​jozefizso](https://togithub.com/jozefizso) made their first contribution in [dorny/test-reporter#317 - [@​wingyplus](https://togithub.com/wingyplus) made their first contribution in [dorny/test-reporter#236 - [@​ldaneliukas](https://togithub.com/ldaneliukas) made their first contribution in [dorny/test-reporter#144 **Full Changelog**: dorny/test-reporter@v1.7.0...v1.8.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/splunk/addonfactory-workflow-addon-release). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #319
According to the documentation of the TestDoneEvent, the hidden "tests" should be ignored:
hiddenflag set totrue