Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hasura-allow-list):add config to change fragments definition order #452

Merged
merged 2 commits into from Oct 19, 2023

Conversation

shoma-mano
Copy link
Contributor

@shoma-mano shoma-mano commented Oct 15, 2023

Description

add config to change fragments definition order.
Related #441

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I tested by new test code, and it generates allow list that define fragments in order they appear in the document when fragmentsOrder is set to document, and this allow list is compatible with some other plugins that did not work before. Default setting is global, and this works the same as before. So this is not breaking change.

Test Environment:

  • OS:macOS Ventura v13.4
  • NodeJS:v19.9.0

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2023

🦋 Changeset detected

Latest commit: 8ae3f7f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/hasura-allow-list Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@saihaj saihaj merged commit 0fea1a8 into dotansimha:main Oct 19, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants