Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The types of pluckConfig is incorrect #8579

Closed
rwu823 opened this issue Nov 7, 2022 · 1 comment
Closed

The types of pluckConfig is incorrect #8579

rwu823 opened this issue Nov 7, 2022 · 1 comment
Labels
core Related to codegen core/cli

Comments

@rwu823
Copy link
Contributor

rwu823 commented Nov 7, 2022

Describe the bug

The current types definition of config is as follows left side:

image

This is incorrect and differs from the document.
image

Your Example Website or App

none

Steps to Reproduce the Bug or Issue

  1. create a codegen.ts config.
  2. import the CodegenConfig types from @graphql-codegen/cli
  3. check the pluckConfig types

Expected behavior

should get correct types of pluckConfig

Screenshots or Videos

No response

Platform

  • "@graphql-codegen/cli": "2.13.11"

Codegen Config File

import { CodegenConfig } from '@graphql-codegen/cli';

const config: CodegenConfig = {
  pluckConfig: {
    magicComment: 'GraphQL',
//       ^? incorrect type, should be `gqlMagicComment`
    globalIdentifier: 'gql',
//       ^? incorrect type, should be `globalGqlIdentifierName`
  },
}

Additional context

If you are all good, I can create a PR for fixing this.

@charlypoly charlypoly added the core Related to codegen core/cli label Nov 8, 2022
@rwu823 rwu823 mentioned this issue Jan 11, 2023
9 tasks
@rwu823
Copy link
Contributor Author

rwu823 commented Jan 19, 2023

Closed for #8808 fixed.

@rwu823 rwu823 closed this as completed Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Related to codegen core/cli
Projects
None yet
Development

No branches or pull requests

2 participants