Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gqlMagicComment type #8808

Merged
merged 2 commits into from Jan 17, 2023
Merged

fix: gqlMagicComment type #8808

merged 2 commits into from Jan 17, 2023

Conversation

rwu823
Copy link
Contributor

@rwu823 rwu823 commented Jan 11, 2023

Description

fix incorrect type.

Related #8579

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@changeset-bot
Copy link

changeset-bot bot commented Jan 11, 2023

🦋 Changeset detected

Latest commit: 0cb5659

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphql-codegen/cli Patch
@graphql-cli/codegen Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@saihaj
Copy link
Collaborator

saihaj commented Jan 11, 2023

Can you add patch changeset read more #8808 (comment)

@rwu823
Copy link
Contributor Author

rwu823 commented Jan 12, 2023

@saihaj Added.

@saihaj
Copy link
Collaborator

saihaj commented Jan 13, 2023

@rwu823 looks like prettier is failing

@rwu823
Copy link
Contributor Author

rwu823 commented Jan 15, 2023

@saihaj next.config.mjs It looks not my modification.

image

And I tried run prettier:check on my local is passed. Could you help to re-run it?

image

@saihaj saihaj merged commit 884d25c into dotansimha:master Jan 17, 2023
@saihaj
Copy link
Collaborator

saihaj commented Jan 17, 2023

thanks @rwu823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants