Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix apollo react #2344

Merged
merged 2 commits into from
Sep 22, 2019
Merged

Prefix apollo react #2344

merged 2 commits into from
Sep 22, 2019
+362 −2

Conversation

veeramarni
Copy link
Contributor

@veeramarni veeramarni commented Aug 12, 2019 •
edited
Loading

Inorder the preset to work for typescript-react-apollo. However, this may not be the best way and it would be better the core visitor class can handle preset configuration so that all plugins uniformly get the same prefix. Relates to #2165

@veeramarni
Copy link
Contributor Author

@dotansimha Wondering if you got chance to review this PR and other one #2344

@dotansimha
Copy link
Owner

@veeramarni please see my comments. Thanks!

@veeramarni
Copy link
Contributor Author

@dotansimha Will update the PR shortly.

@veeramarni
Copy link
Contributor Author

@dotansimha Can you please respond to my comments?

@dotansimha
Copy link
Owner

Hi @veeramarni ! Thank you for the answer. Can you please just rebase and resolve the conflicts?

@dotansimha dotansimha merged commit 5622098 into dotansimha:master Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotansimha dotansimha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@veeramarni @dotansimha