fix(visitor-plugin-common): also include empty selection set types/generate valid type output #2490
+58
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1ru4l
changed the title
|
There is an issue with flow types that must be fixed: d49dbba I am on vacation for the next two weeks so someone else could pick this up and finish it. Typescript part is fine. |
|
Thanks @n1ru4l , I'm doing some more fixes for the selection set transformation, also changed this current fix to output more clear code (without empty objects). Thanks!! |
|
@dotansimha Removing the empty objects could possibly result in incorrect types |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue occurring in #2489