Kotlin code generator #2598
Merged
Kotlin code generator #2598
+581
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome! Thank you so much @tristanlins ! We'll review it very soon :) |
Propagate the default values into kotlin. The most benefit is in unit tests.
Let is not necessary, for non-null values.
Reduce compiler warnings.
|
After using the plugin myself in a productive project, a few bumps have been noticed. I have revised it again. |
dotansimha
reviewed
Sep 24, 2019
dotansimha
reviewed
Sep 24, 2019
|
Awesome @tristanlins ! Thank you! |
|
Merged, thank you @tristanlins ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kotlin Generator based / as a copy of the Java Generator.
When generating Kotlin code, there were significant differences, so I built a new generator and did not make the Java Generator switchable.
BTW: Thanks for this great project 🤗