Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client-preset: allow skipDocumentsValidation in config #9653

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

schmod
Copy link
Contributor

@schmod schmod commented Aug 29, 2023

Description

Fixes a small issue raised in #8562

It appears that this line is necessary for skipDocumentsValidation to work when using the client-preset, as the setting is otherwise stripped out without being passed upstream.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I checked in a fixture that uses urql's @populate directive, which violates the ScalarLeafsRule validation rule.

With the changes in this PR, I am able to successfully use the skipDocumentsValidation setting (as documented) to intentionally bypass this particular validation. Without the changes in this PR, the validation (that I asked to be skipped) will cause the codegen to fail when it is used alongside the client-preset.

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • N/A I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • N/A Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2023

⚠️ No Changeset found

Latest commit: bf40f6e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@schmod schmod changed the title Client preset pass through skip documents validation client-preset: allow "skip documents validation" in config Sep 5, 2023
@schmod schmod changed the title client-preset: allow "skip documents validation" in config client-preset: allow skipDocumentsValidation in config Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant