Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve makeFragmentData type problem by creating unmask Fragment utility type #9708

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

resolve makeFragmentData type problem by creating unmask Fragment utility type #9708

wants to merge 10 commits into from

Commits on Mar 8, 2024

  1. implement the fragment unmasking utility and update makeFragment type

    @tnyo43
    tnyo43 committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    4996b72 View commit details
    Browse the repository at this point in the history

  2. remove importing ResultOf statement 

    it is not required since the previous commit
    @tnyo43
    tnyo43 committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    d43e933 View commit details
    Browse the repository at this point in the history

  3. generate examples 

    run `yarn build & yarn generate:examples`
    @tnyo43
    tnyo43 committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    e72e202 View commit details
    Browse the repository at this point in the history

  4. fix graphql function in dev-test 

    gql function seems not to be used since dotansimha#9217 is completed
    @tnyo43
    tnyo43 committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    8a95e64 View commit details
    Browse the repository at this point in the history

  5. add mock data created by using makeFragmentData 

    this mock data is what is not able to be typed with the previous `makeFragmentData` function.
That is because `TweetsFragment` includes two different fragments
    @tnyo43
    tnyo43 committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    7c9c96a View commit details
    Browse the repository at this point in the history

  6. run codegen in examples 

    run `yarn examples:codegen`
    @tnyo43
    tnyo43 committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    4b2e131 View commit details
    Browse the repository at this point in the history

  7. update snapshot

    @tnyo43
    tnyo43 committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    82b05fb View commit details
    Browse the repository at this point in the history

  8. add changeset

    @tnyo43
    tnyo43 committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    1faeb31 View commit details
    Browse the repository at this point in the history

  9. add tests for makeFragmentData

    @tnyo43
    tnyo43 committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    3315b9e View commit details
    Browse the repository at this point in the history

  10. update type assertion to any. 

    the reason of this change is to escape the error of type error. refer to https://github.com/dotansimha/graphql-code-generator/actions/runs/6523101984/job/17713396917?pr=9708
    @tnyo43
    tnyo43 committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    015cefe View commit details
    Browse the repository at this point in the history