Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] Fixed graphiql ignoring options if GraphiQLOptionFactory returns Promise #2246

Merged
merged 1 commit into from Dec 26, 2022

Conversation

izumin5210
Copy link
Contributor

from #1747 (comment)

Port #1965 for v3

@changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2022

🦋 Changeset detected

Latest commit: 21f4020

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-yoga/common Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ardatan ardatan merged commit d3d0004 into dotansimha:main Dec 26, 2022
@github-actions
Copy link
Contributor

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 197224      ✗ 0    
     data_received..................: 28 MB   924 kB/s
     data_sent......................: 11 MB   378 kB/s
     http_req_blocked...............: avg=1.12µs   min=800ns   med=1µs     max=294.4µs p(90)=1.3µs   p(95)=1.6µs  
     http_req_connecting............: avg=1ns      min=0s      med=0s      max=117.7µs p(90)=0s      p(95)=0s     
   ✓ http_req_duration..............: avg=235.34µs min=167.9µs med=212.4µs max=18.6ms  p(90)=254.8µs p(95)=287.4µs
       { expected_response:true }...: avg=235.34µs min=167.9µs med=212.4µs max=18.6ms  p(90)=254.8µs p(95)=287.4µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 98612
     http_req_receiving.............: avg=17.51µs  min=10.3µs  med=15.1µs  max=8.82ms  p(90)=20.6µs  p(95)=22.9µs 
     http_req_sending...............: avg=5.69µs   min=3.9µs   med=4.59µs  max=5.48ms  p(90)=6µs     p(95)=7.2µs  
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=212.13µs min=149.4µs med=193.1µs max=18.51ms p(90)=227.9µs p(95)=256.1µs
     http_reqs......................: 98612   3286.935456/s
     iteration_duration.............: avg=299.56µs min=222.1µs med=270.7µs max=19.03ms p(90)=326.9µs p(95)=365.8µs
     iterations.....................: 98612   3286.935456/s
     vus............................: 0       min=0         max=1  
     vus_max........................: 1       min=1         max=1  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants