Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add allowedHeaders option to allow filtering Response and Request headers #3188

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add allowedHeaders option to allow filtering Response and Request headers #3188

wants to merge 6 commits into from

Conversation

EmrysMyrddin
Copy link
Collaborator

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2024 •
edited

🦋 Changeset detected

Latest commit: 2b34a0e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@graphql-yoga/nestjs Major
@graphql-yoga/nestjs-federation Patch
@graphql-yoga/plugin-apollo-inline-trace Major
@graphql-yoga/plugin-apq Major
@graphql-yoga/plugin-csrf-prevention Major
@graphql-yoga/plugin-defer-stream Major
@graphql-yoga/plugin-disable-introspection Major
@graphql-yoga/plugin-graphql-sse Major
@graphql-yoga/plugin-jwt Major
@graphql-yoga/plugin-persisted-operations Major
@graphql-yoga/plugin-prometheus Major
@graphql-yoga/plugin-response-cache Major
@graphql-yoga/plugin-sofa Major
@graphql-yoga/render-graphiql Major
graphql-yoga Minor
graphql-yoga-cloud-run-guide Patch
hello-world-benchmark Patch
apollo-federation-gateway-with-yoga Patch
apollo-subgraph-with-yoga Patch
graphql-lambda Patch
cloudflare-advanced Patch
cloudflare Patch
functions Patch
hackernews Patch
nextjs-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 19, 2024 •
edited

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 19, 2024 •
edited

💻 Website Preview

The latest changes are available as preview in: https://ccb119ba.graphql-yoga.pages.dev

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 19, 2024 •
edited

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}

     checks.......................................: 100.00% ✓ 412488      ✗ 0     
     data_received................................: 1.7 GB  14 MB/s
     data_sent....................................: 83 MB   694 kB/s
     http_req_blocked.............................: avg=1.41µs   min=972ns    med=1.29µs   max=261.17µs p(90)=1.82µs   p(95)=2.02µs  
     http_req_connecting..........................: avg=2ns      min=0s       med=0s       max=146.1µs  p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=373.57µs min=210.97µs med=332.21µs max=14.24ms  p(90)=531.32µs p(95)=550.23µs
       { expected_response:true }.................: avg=373.57µs min=210.97µs med=332.21µs max=14.24ms  p(90)=531.32µs p(95)=550.23µs
     ✓ { mode:graphql-jit }.......................: avg=277.14µs min=210.97µs med=257.15µs max=14.24ms  p(90)=286.16µs p(95)=296.4µs 
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=555.96µs min=466.1µs  med=530.86µs max=9.41ms   p(90)=569.53µs p(95)=597.16µs
     ✓ { mode:graphql-response-cache }............: avg=352.38µs min=280.78µs med=333.6µs  max=10.36ms  p(90)=364.92µs p(95)=375.55µs
     ✓ { mode:graphql }...........................: avg=373.79µs min=289.98µs med=341.63µs max=12.76ms  p(90)=384.52µs p(95)=432.46µs
     http_req_failed..............................: 0.00%   ✓ 0           ✗ 206244
     http_req_receiving...........................: avg=31.71µs  min=16.86µs  med=31.81µs  max=821.09µs p(90)=37.51µs  p(95)=39.5µs  
     http_req_sending.............................: avg=7.86µs   min=5.77µs   med=7.13µs   max=759.07µs p(90)=10.34µs  p(95)=10.99µs 
     http_req_tls_handshaking.....................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=333.99µs min=179.03µs med=293.4µs  max=14.14ms  p(90)=491.65µs p(95)=508.37µs
     http_reqs....................................: 206244  1718.673243/s
     iteration_duration...........................: avg=577.07µs min=375.92µs med=531.55µs max=14.79ms  p(90)=738.18µs p(95)=761.07µs
     iterations...................................: 206244  1718.673243/s
     vus..........................................: 1       min=1         max=1   
     vus_max......................................: 2       min=2         max=2

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 19, 2024 •
edited

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
graphql-yoga-cloud-run-guide 3.2.0-alpha-20240322103234-2b34a0e7 npm ↗︎ unpkg ↗︎
@graphql-yoga/apollo-link 3.2.0-alpha-20240322103234-2b34a0e7 npm ↗︎ unpkg ↗︎
@graphql-yoga/urql-exchange 3.2.0-alpha-20240322103234-2b34a0e7 npm ↗︎ unpkg ↗︎
graphql-yoga 5.2.0-alpha-20240322103234-2b34a0e7 npm ↗︎ unpkg ↗︎
@graphql-yoga/nestjs 3.2.0-alpha-20240322103234-2b34a0e7 npm ↗︎ unpkg ↗︎
@graphql-yoga/nestjs-federation 3.2.0-alpha-20240322103234-2b34a0e7 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apollo-inline-trace 3.2.0-alpha-20240322103234-2b34a0e7 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apq 3.2.0-alpha-20240322103234-2b34a0e7 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-csrf-prevention 3.2.0-alpha-20240322103234-2b34a0e7 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-defer-stream 3.2.0-alpha-20240322103234-2b34a0e7 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-disable-introspection 2.2.0-alpha-20240322103234-2b34a0e7 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-graphql-sse 3.2.0-alpha-20240322103234-2b34a0e7 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-jwt 2.2.0-alpha-20240322103234-2b34a0e7 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-persisted-operations 3.2.0-alpha-20240322103234-2b34a0e7 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-prometheus 4.1.0-alpha-20240322103234-2b34a0e7 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-response-cache 3.4.0-alpha-20240322103234-2b34a0e7 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-sofa 3.2.0-alpha-20240322103234-2b34a0e7 npm ↗︎ unpkg ↗︎
@graphql-yoga/render-graphiql 5.2.0-alpha-20240322103234-2b34a0e7 npm ↗︎ unpkg ↗︎

ardatan
ardatan reviewed Mar 22, 2024
View reviewed changes
packages/graphql-yoga/src/server.ts
@@ -341,45 +353,28 @@ export class YogaServer<
}),

...(options?.plugins ?? []),
// To make sure those are called at the end
{
onPluginInit({ addPlugin }) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this ensures that those plugins are always at the end. Otherwise plugins that add new plugins come after these.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addPlugin no longer adds plugins at the end of the plugin list. It adds the plugin in place, so this is no longer needed :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardatan ardatan ardatan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EmrysMyrddin @ardatan