Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(docs): Provide example for APQ in case of outage #3213

Merged
merged 4 commits into from May 17, 2024

Conversation

jdolle
Copy link
Contributor

@jdolle jdolle commented Mar 26, 2024

Solves #3204

Copy link

changeset-bot bot commented Mar 26, 2024

⚠️ No Changeset found

Latest commit: c3b6538

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@EmrysMyrddin
Copy link
Collaborator

Thank you for this contribution, very appreciated!
I've made some minor comment, otherwise it should be ok to merge 🙂

@@ -119,6 +119,36 @@ server.listen(4000, () => {

For external stores the `set` and `get` properties on the store can also return a `Promise`.

In production, it's recommended to capture the errors from any store that could stop functioning.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be a new sub-menu item ## Graceful Error Handling

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like this in addition to the <Callout>? Which is preferred?

jdolle and others added 3 commits March 26, 2024 11:06
@EmrysMyrddin EmrysMyrddin merged commit ecdcdd8 into dotansimha:main May 17, 2024
5 checks passed
Copy link
Contributor

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}

     checks.......................................: 100.00% ✓ 400352      ✗ 0     
     data_received................................: 1.6 GB  14 MB/s
     data_sent....................................: 81 MB   673 kB/s
     http_req_blocked.............................: avg=1.44µs   min=961ns    med=1.29µs   max=281.59µs p(90)=1.9µs    p(95)=2.1µs   
     http_req_connecting..........................: avg=2ns      min=0s       med=0s       max=145.75µs p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=387.87µs min=218.16µs med=344.5µs  max=23.73ms  p(90)=544.73µs p(95)=563.87µs
       { expected_response:true }.................: avg=387.87µs min=218.16µs med=344.5µs  max=23.73ms  p(90)=544.73µs p(95)=563.87µs
     ✓ { mode:graphql-jit }.......................: avg=290.52µs min=218.16µs med=269.08µs max=14.45ms  p(90)=298.72µs p(95)=311.46µs
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=572.08µs min=485.44µs med=544.04µs max=9.98ms   p(90)=584.43µs p(95)=616.92µs
     ✓ { mode:graphql-response-cache }............: avg=366.91µs min=293.01µs med=347.87µs max=16.08ms  p(90)=379.39µs p(95)=390.7µs 
     ✓ { mode:graphql }...........................: avg=385.92µs min=295.71µs med=351.64µs max=23.73ms  p(90)=394.12µs p(95)=456.41µs
     http_req_failed..............................: 0.00%   ✓ 0           ✗ 200176
     http_req_receiving...........................: avg=33.2µs   min=15.91µs  med=33.25µs  max=980.58µs p(90)=38.76µs  p(95)=41.02µs 
     http_req_sending.............................: avg=8.4µs    min=6.18µs   med=7.41µs   max=8.79ms   p(90)=10.92µs  p(95)=11.62µs 
     http_req_tls_handshaking.....................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=346.26µs min=187.7µs  med=303.82µs max=23.6ms   p(90)=502.89µs p(95)=520.02µs
     http_reqs....................................: 200176  1668.115481/s
     iteration_duration...........................: avg=594.58µs min=389.59µs med=547.1µs  max=24.67ms  p(90)=754.65µs p(95)=777.91µs
     iterations...................................: 200176  1668.115481/s
     vus..........................................: 1       min=1         max=1   
     vus_max......................................: 2       min=2         max=2   

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants