Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root Level Limit: different take with onValidate #3236

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented Apr 15, 2024

Different take for #3233

Copy link

changeset-bot bot commented Apr 15, 2024

⚠️ No Changeset found

Latest commit: e83084c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

Copy link
Contributor

diff --git a/website/route-lockfile.txt b/website/route-lockfile.txt
index 3512515d..3054e5c4 100644
--- a/website/route-lockfile.txt
+++ b/website/route-lockfile.txt
@@ -23,6 +23,7 @@
 /docs/features/persisted-operations
 /docs/features/request-batching
 /docs/features/response-caching
+/docs/features/root-level-limitation
 /docs/features/schema
 /docs/features/sofa-api
 /docs/features/subscriptions

Copy link
Contributor

💻 Website Preview

The latest changes are available as preview in: https://f3b809b3.graphql-yoga.pages.dev

Copy link
Contributor

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}

     checks.......................................: 100.00% ✓ 393416      ✗ 0     
     data_received................................: 1.6 GB  13 MB/s
     data_sent....................................: 79 MB   662 kB/s
     http_req_blocked.............................: avg=1.48µs   min=952ns    med=1.31µs   max=248.88µs p(90)=1.98µs   p(95)=2.18µs  
     http_req_connecting..........................: avg=2ns      min=0s       med=0s       max=148.06µs p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=395.88µs min=223.5µs  med=352.96µs max=24ms     p(90)=549.39µs p(95)=570.66µs
       { expected_response:true }.................: avg=395.88µs min=223.5µs  med=352.96µs max=24ms     p(90)=549.39µs p(95)=570.66µs
     ✓ { mode:graphql-jit }.......................: avg=295.69µs min=223.5µs  med=271.72µs max=18.52ms  p(90)=303.89µs p(95)=320.78µs
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=581.17µs min=479.88µs med=547.83µs max=10.14ms  p(90)=594.64µs p(95)=637.02µs
     ✓ { mode:graphql-response-cache }............: avg=377.01µs min=299.98µs med=357.06µs max=9.48ms   p(90)=388.24µs p(95)=399.55µs
     ✓ { mode:graphql }...........................: avg=394.54µs min=303.27µs med=359.39µs max=24ms     p(90)=406.56µs p(95)=457.62µs
     http_req_failed..............................: 0.00%   ✓ 0           ✗ 196708
     http_req_receiving...........................: avg=34.07µs  min=17.28µs  med=33.91µs  max=873.55µs p(90)=39.86µs  p(95)=42.18µs 
     http_req_sending.............................: avg=8.33µs   min=5.79µs   med=7.32µs   max=5.77ms   p(90)=10.84µs  p(95)=11.83µs 
     http_req_tls_handshaking.....................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=353.46µs min=190.3µs  med=311.15µs max=23.87ms  p(90)=506.63µs p(95)=525.73µs
     http_reqs....................................: 196708  1639.135858/s
     iteration_duration...........................: avg=605.23µs min=394.09µs med=558.96µs max=24.62ms  p(90)=762.59µs p(95)=788.48µs
     iterations...................................: 196708  1639.135858/s
     vus..........................................: 1       min=1         max=1   
     vus_max......................................: 2       min=2         max=2   

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants