Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ASP.NET Core documentation for 6.6.1 release #2857

Open
martincostello opened this issue May 8, 2024 · 9 comments · Fixed by dotnet/AspNetCore.Docs#32576
Open

Update ASP.NET Core documentation for 6.6.1 release #2857

martincostello opened this issue May 8, 2024 · 9 comments · Fixed by dotnet/AspNetCore.Docs#32576
Assignees
Milestone

Comments

@martincostello
Copy link
Collaborator

martincostello commented May 8, 2024

Raise a pull request to edit getting-started-with-swashbuckle.md once Swashbuckle.AspNetCore 6.6.1 is released to:

  1. Remove the banner stating that .NET 8 is not supported.
  2. Remove the reference to Schema Metadata for C# 9 Records #1920.

See dotnet/AspNetCore.Docs#32477 (comment).

@martincostello martincostello added this to the v6.6.0 milestone May 8, 2024
@martincostello martincostello self-assigned this May 8, 2024
@martincostello martincostello modified the milestones: v6.6.0, v6.6.1 May 14, 2024
@martincostello martincostello changed the title Update ASP.NET Core documentation for 6.6.0 release Update ASP.NET Core documentation for 6.6.1 release May 14, 2024
martincostello added a commit to martincostello/AspNetCore.Docs that referenced this issue May 14, 2024
- Remove unsupported notice for .NET 8.
- Update package version numbers.
- Remove reference to resolved issue.

Resolves domaindrivendev/Swashbuckle.AspNetCore#2857.
@captainsafia
Copy link
Contributor

@martincostello Thoughts on updating the templates in 8.0 as well?

@martincostello
Copy link
Collaborator Author

@captainsafia Do you mean the versions referenced by the templates in dotnet/aspnetcore? If so I'm happy to do that if that meets the backport bar.

@captainsafia
Copy link
Contributor

@captainsafia Do you mean the versions referenced by the templates in dotnet/aspnetcore? If so I'm happy to do that if that meets the backport bar.

Yep, that's what I meant. I think we can make the case for it given that .NET 8 is LTS and the lack of support for net8.0 in 6.5.0 is a blocker for build-time doc gen.

@martincostello
Copy link
Collaborator Author

OK cool - I'll do a PR for that tomorrow 👍

@cremor
Copy link
Contributor

cremor commented May 14, 2024

Maybe wait with the template update until 6.6.2 is released? Or even a bit longer to give people the chance to test the new version and report bugs.

@captainsafia
Copy link
Contributor

Maybe wait with the template update until 6.6.2 is released? Or even a bit longer to give people the chance to test the new version and report bugs.

Good point! Given the volume of changes that were merged over the past few weeks, it might be good to give things more bake time.

@cremor
Copy link
Contributor

cremor commented May 17, 2024

Thoughts on updating the templates in 8.0 as well?

Is this actually feasible? I've just learned that no template changes for existing major .NET versions can be shipped without a "patching request" path and adding features/bumping versions would not meet the bar of value vs risk. Source: dotnet/test-templates#388 (comment)

And .NET 9 templates will not include Swashbuckle at all (see dotnet/aspnetcore#54599).

@martincostello
Copy link
Collaborator Author

It is yes feasible, yes - that's specifically what I already asked Safia already: #2857 (comment).

If a member of the .NET team thinks it's a good idea, then it's at least worth opening a PR as presumably they would support the PR getting approved by their process.

And .NET 9 templates will not include Swashbuckle at all

We know this - but this is a conversation about .NET 8, which is supported until November 2026.

@martincostello
Copy link
Collaborator Author

martincostello commented May 21, 2024

I'll give 6.6.2 a few days to bed-in, then if we don't get any big new issues from 6.6.x I'll do the PR to the release/8.0 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants