Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Swashbuckle documentation #32576

Merged
merged 2 commits into from
May 14, 2024

Conversation

martincostello
Copy link
Member

@martincostello martincostello commented May 14, 2024

- Remove unsupported notice for .NET 8.
- Update package version numbers.
- Remove reference to resolved issue.

Resolves domaindrivendev/Swashbuckle.AspNetCore#2857.
@guardrex guardrex mentioned this pull request May 14, 2024
@captainsafia
Copy link
Member

Looks good overall!

Do you mind also updating the references to Swashbuckle.AspNetCore versions elsewhere in the docs? I'm thinking specifically about 8.x samples that reference 6.5.x (see here)?

@martincostello
Copy link
Member Author

Sure - I'll take a look - it didn't occur to me to look elsewhere in the docs 馃槃

Update additional example commands.
@martincostello
Copy link
Member Author

@captainsafia I did a quick look, and most of the remaining references are all package versions in the samples. A lot of those depend on pre-release versions of .NET from when the content was originally authored, so I figured trying to update those too would snowball fast into a whole world of pain 馃槄

@captainsafia
Copy link
Member

@captainsafia I did a quick look, and most of the remaining references are all package versions in the samples. A lot of those depend on pre-release versions of .NET from when the content was originally authored, so I figured trying to update those too would snowball fast into a whole world of pain 馃槄

No problem. I think we can do a selective look into which need updating separately. I think the fact that the version number is updating in the new doc is most important.

@captainsafia captainsafia merged commit a713e98 into dotnet:main May 14, 2024
3 checks passed
@martincostello martincostello deleted the update-swashbuckle-docs branch May 14, 2024 17:20
@cremor
Copy link

cremor commented May 14, 2024

Why even specify package version numbers in the docs? You recently updated the Swashbuckle.AspNetCore readme file and remove the explicit version numbers. Wouldn't the same make sense for the docs? Then it would always be current.

@martincostello
Copy link
Member Author

What we do in our docs is different to what Microsoft do in their docs - I just did the minimal change which is to bump them, rather than question why they specified a version in the first place.

Removing them entirely is a separate conversation.

@captainsafia
Copy link
Member

Why even specify package version numbers in the docs?

We manage docs for multiple versions of .NET in the Microsoft docs page. Providing specific package versions in each docs page allows us to maintain more high quality docs when package versions might differ across TFMs for example. This is especially important for communicating what version of Swashbuckle.AspNetCore works with .NET 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ASP.NET Core documentation for 6.6.1 release
3 participants