Protobuf scalar default values and ByteString detail #19769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Performance warning: this copy copies byte[] how many times? |
|
For reading values, Memory/Span properties exist. For creating values there is discussion about adding an unsafe API - protocolbuffers/protobuf#7645 If it does get added I don't think it is appropriate to talk about in this doc, since it is a general usage guide. The performance guide would be a better place to discuss how to be efficient when sending byte payloads with gRPC. |
JamesNK
force-pushed
the
jamesnk/protobuf-feedback
branch
from
fe55286
to
03b7e08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19760
@jskeet