Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not intercept output from MSBuild #1739

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yecril71pl
Copy link
Contributor

Do not intercept output from MSBuild
Fixes #1738

Class MsBuildProjectContextBuilder is not being tested. Moreover, we have no control over what MSBuild writes to standard output, so there is nothing to assert.

Do not intercept output from MSBuild
Fixes dotnet#1738
@deepchoudhery
Copy link
Contributor

We can discuss here but I tend to prefer the standard output being redirected. Seeing the build output provides more clarity to VS and command line users as to the scaffolding process. It is not particularly verbose and can highlight warnings that may cause scaffolding to fail. Helps users and me alike to solve any issues with scaffolders and especially custom scaffolders. That's just my take on it.
Let me know how you feel @yecril71pl.

@yecril71pl
Copy link
Contributor Author

Seeing the build output

You can see the build output in two ways:

  1. Just let the subprocess do its thing.
  2. Intercept all output from the subprocess and present it ourselves.

This change switches from mode 2 to mode 1. Mode 2 makes sense when we do something to the output, like code page conversion, injecting time stamps, teeing into a secondary logger or whatever. We do not do any of these things, so I would rather prefer it raw, if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MsBuildProjectContextBuilder drops MSBuild output on the floor
2 participants