Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal - 3.0 Additional types for Silk.NET.Maths #1806

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

dfkeenan
Copy link

Summary of the PR

A proposal for additional types to the Silk.NET.Maths library for 3.0.

Related issues, Discord discussions, or proposals

As discussed in discord with the SilkX team.

@dfkeenan
Copy link
Author

@dotnet-policy-service agree

@Perksey
Copy link
Member

Perksey commented Feb 21, 2024

Provisionally adding this to the next working group meeting agenda (date not yet set)

@Perksey Perksey added this to the Next Working Group Meeting milestone Feb 21, 2024
@uwx
Copy link

uwx commented Apr 24, 2024

Angle (and other such types) shouldn't have a public constructor, that completely voids the point of having the type as it's not clear what underlying unit is being passed in without reading the code. That's why we have FromDegrees and FromRadians. Angle.Sin(new Angle(1.0)) is no more clear than Math.Sin(1.0), but Angle.Sin(Angle.FromRadians(1.0)) is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

None yet

3 participants