start of adding touch input #1898
Open
+1,213
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where? |
On discord. But my memory was poor. It was more a question and you said I can give it a try. I guess I started to work on this a bit later but then abandonded it because of time.
|
|
Thanks |
Beyley
reviewed
Jan 14, 2024
Comment on lines
23
to
36
| /// <summary> | ||
| /// The last known normalized position of the finger. | ||
| /// </summary> | ||
| public Vector2 NormalizedPosition { get; } | ||
|
|
||
| /// <summary> | ||
| /// The last known speed of the finger. | ||
| /// </summary> | ||
| public Vector2 Speed { get; } | ||
|
|
||
| /// <summary> | ||
| /// The last known normalized speed of the finger. | ||
| /// </summary> | ||
| public Vector2 NormalizedSpeed { get; } |
There was a problem hiding this comment.
Could there be some documentation in here about what normalized means in this specific context? In the case of graphics programming this could very well mean -1 -> 1 or 0 -> 1
There was a problem hiding this comment.
I added (0..1) and (-1..1). Is this enough? In general positions are normalized to range 0 to 1 and speed values to range -1 to 1 as they have a direction. I tried to add this information everywhere before but forgot it here I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This adds touch devices to the input abstraction. The goal is to add touch gesture recognition to the SDL backend to enable touch gestures and simple touch finger events on Android and iOS.
Related issues, Discord discussions, or proposals
I proposed this a long time ago and finally found some time for it.