-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AWS Console urls in the dashboard for CloudFormation stacks and resources #4106
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool feature adding the console links to the stacks.
src/Aspire.Hosting.AWS/CloudFormation/CloudFormationAWSConsoleUrlMapper.cs
Outdated
Show resolved
Hide resolved
src/Aspire.Hosting.AWS/CloudFormation/CloudFormationAWSConsoleUrlMapper.cs
Outdated
Show resolved
Hide resolved
src/Aspire.Hosting.AWS/CloudFormation/CloudFormationAWSConsoleUrlMapper.cs
Outdated
Show resolved
Hide resolved
src/Aspire.Hosting.AWS/CloudFormation/CloudFormationProvisioner.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@davidfowl an e2e test is failing. Should I push a commit to re-trigger? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This PR adds URLs in the Aspire Dashboard to the AWS Console for CloudFormation Stacks and a selection of AWS resource types that are commonly used in local development. The resource types are: SQS Queues, SNS Topics, S3 Buckets, Cognito UserPools and DynamoDB Tables/GlobalTables.
It could be that the CloudFormation URL is sufficient but the CloudFormation-panel does not provide URLs for SQS Queues or Global Tables. It's also an extra navigation step. I will let review decide that.
Microsoft Reviewers: Open in CodeFlow