-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional serviceName
parameter to WithReference
methods
#4111
base: main
Are you sure you want to change the base?
Conversation
43d1269
to
c41a7e9
Compare
Can't make breaking changes like this now. Add an overload. |
Updated the `WithReference` methods in `ResourceBuilderExtensions.cs` to include an optional `serviceName` parameter for overriding the source resource's name for the service name. The `ApplyEndpoints` and `CreateEndpointReferenceEnvironmentPopulationCallback` methods have been updated to use this new parameter. Updated and added tests in `WithReferenceTests.cs` to cover these changes. The `PublicAPI.Unshipped.txt` file has also been updated to reflect these changes.
c41a7e9
to
c1b7a76
Compare
Done! |
@ReubenBond can you take a look? |
@ReubenBond and @davidfowl I'm thinking that a better pattern here might be to do something like this: public static IResourceBuilder<TDestination> WithReference<TDestination>(this IResourceBuilder<TDestination> builder, IResourceBuilder<IResourceWithServiceDiscovery> source, ServiceDiscoveryOptions options) |
Does |
Updated the
WithReference
methods inResourceBuilderExtensions.cs
to include an optionalserviceName
parameter for overriding the source resource's name for the service name. TheApplyEndpoints
andCreateEndpointReferenceEnvironmentPopulationCallback
methods have been updated to use this new parameter. Updated and added tests inWithReferenceTests.cs
to cover these changes. ThePublicAPI.Unshipped.txt
file has also been updated to reflect these changes.Closes #4109
Microsoft Reviewers: Open in CodeFlow