Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Aspire.Hosting.Apache.Pulsar #4146

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

maranmaran
Copy link

@maranmaran maranmaran commented May 10, 2024

Hi 👋, first time contributor here

Motivation

To support Apache Pulsar with Aspire Hosting options

Modifications

  • Aspire.Hosting.Apache.Pulsar lib
  • Pulsar container resource - by default in standalone mode
  • UI Management via Pulsar Manager
  • Playground example
  • Unit tests for hosting package
  • Pulsar component (in my mind, but I wanted to leave it for separate PR and perhaps bring this as a value first)

Sources

Docs: https://pulsar.apache.org/docs/3.2.x/
.NET Client library: https://github.com/apache/pulsar-dotpulsar

Notes:

Please direct me if I'm missing something 😄.

Regarding Pulsar Manager (UI),

I'd like to wait a tiny bit to bump up the default tag of PulsarManagerContainerImageTags so it can support having a default super-user via environment variables which I recently added.

The code is in place with this PR and the manager release should be relatively soon.

Questions:

  1. I was not able to add DotPulsar package into the playground project so I added my own nuget source.
    Hope someone could guide me a little on how to get it into the project from current sources.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label May 10, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 10, 2024
@maranmaran
Copy link
Author

@dotnet-policy-service agree

@dotnet-policy-service agree

@maranmaran maranmaran changed the title feat: support apache pulsar with UI feat: support apache pulsar hosting May 10, 2024
@maranmaran maranmaran changed the title feat: support apache pulsar hosting feat: support Aspire.Hosting.Apache.Pulsar May 10, 2024
@radical radical removed the area-codeflow for labeling automated codeflow. intentionally a different color! label May 10, 2024
# Conflicts:
#	Directory.Packages.props
@maranmaran
Copy link
Author

maranmaran commented Jun 7, 2024

@davidfowl Hello 😄 Hope you don't mind me asking, just searching some general guidance.

If you would be so kind and perhaps point me or refer me to someone on how could I (we) get/whitelist DotPulsar as part of "external dependencies" (like Confluent.Kafka, Dapper and similar). That would make this PR green and pass the PR checks.

In case of this PR I use it in the playground sample 😄

@davidfowl
Copy link
Member

If you would be so kind and perhaps point me or refer me to someone on how could I (we) get/whitelist DotPulsar as part of "external dependencies" (like Confluent.Kafka, Dapper and similar). That would make this PR green and pass the PR checks.

While developing, change nuget.config to add nuget.org as a package source. We'll revert once we're good with the change and mirror the package to the feed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants