New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Remove source-build workaround for sourcelink submodule issue" #39356
Conversation
…dotnet#39324)" This reverts commit 9b049bd.
@dotnet/aspnet-build should we merge this pre-emptively to get builds working again❔ In particular, public builds aren't failing so the CI validation here proves nothing. |
No objections here |
Latest official build worked❕ Now, main question is why public source-build jobs worked but internal ones did not. Any ideas @MichaelSimons❔ |
I don't have any idea. The only difference that I see is the Agent pool. The source build jobs run in a container which I would expect us to be isolated from most machine config changes. |
Hi @MichaelSimons. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
Hmm, there are a couple of differences in our YAML between public and internal, including a few from Arcade-powered Source Build itself. Eg. - name: _PublishArgs
value: /p:Publish=true
/p:GenerateChecksums=true
/p:DotNetPublishBlobFeedKey=$(dotnetfeed-storage-access-key-1)
/p:DotNetPublishBlobFeedUrl=https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json
/p:DotNetPublishToBlobFeed=$(_DotNetPublishToBlobFeed)
/p:DotNetPublishUsingPipelines=$(_PublishUsingPipelines)
/p:DotNetArtifactsCategory=$(_DotNetArtifactsCategory) We use that variable in the source-build.yml job: |
@@ -13,6 +14,19 @@ | |||
WorkingDirectory="$(InnerSourceBuildRepoRoot)" /> | |||
</Target> | |||
|
|||
<!-- | |||
Init submodules - temporarary workaround for https://github.com/dotnet/sourcelink/pull/653 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dotnet/sourcelink#653 was fixed by @tmat in 2018. perhaps file a new issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are tracking the backport of this patch with dotnet/source-build#2708.
This reverts commit 9b049bd (#39324) as the change broke the internal builds. See https://github.com/dotnet/aspnetcore-internal/issues/3979#issuecomment-1006801036.