Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DisposeAsync in FileStreamResultExecutor #55524

Merged
merged 3 commits into from May 17, 2024
Merged

Use DisposeAsync in FileStreamResultExecutor #55524

merged 3 commits into from May 17, 2024

Conversation

ascott18
Copy link
Contributor

@ascott18 ascott18 commented May 3, 2024

Use DisposeAsync in FileStreamResultExecutor

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

Support file streams that require DisposeAsync

Fixes #55441

ascott18 and others added 3 commits April 30, 2024 13:45
@ascott18
Use DisposeAsync in FileStreamResultExecutor
9dcc8bc 
FileStreamResultExecutor doesn't work well with streams that support and/or require async dispose.
@ascott18
add test
5a4ff5a
@ascott18
fix indentation
7442127
@ascott18 ascott18 requested a review from a team as a code owner May 3, 2024 19:44
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label May 3, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 3, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label May 13, 2024
@davidfowl
Copy link
Member

/azp run

@dotnet-policy-service dotnet-policy-service bot removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label May 13, 2024
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@captainsafia captainsafia merged commit dad78b3 into dotnet:main May 17, 2024
26 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview5 milestone May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainsafia captainsafia captainsafia approved these changes

Assignees

@adityamandaleeka adityamandaleeka

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
9.0-preview5
Development

Successfully merging this pull request may close these issues.

FileStreamResultExecutor does not support DisposeAsync
4 participants
@ascott18 @davidfowl @captainsafia @adityamandaleeka