Make DefaultProblemDetailsFactory public #55666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-mvc
dotnet-policy-service
bot
added
the
community-contribution
gfoidl
reviewed
May 14, 2024
| /// It provides methods to create instances of `ProblemDetails` and `ValidationProblemDetails` with default settings. | ||
| /// This class uses the provided `ApiBehaviorOptions` for client error mapping and an optional custom configuration action to further customize the problem details. | ||
| /// </summary> | ||
| public sealed class DefaultProblemDetailsFactory : ProblemDetailsFactory |
There was a problem hiding this comment.
@GiovanniBraconi please address the analyzer-failure.
Have a look at How to use Microsoft.CodeAnalysis.PublicApiAnalyzers and see at the files in https://github.com/dotnet/aspnetcore/tree/main/src/Mvc/Mvc.Core/src folder.
There was a problem hiding this comment.
Hi @gfoidl; sorry for the late response. It should work fine now 😄
Next time i will write a status update in the description to let other people know i'm still working on the PR.
- Add DefaultProblemDetailsFactory.cs constructor and methods to PublicAPI.Unshipped.txt - Remove duplicated xml comments from methods
captainsafia
approved these changes
May 17, 2024
There was a problem hiding this comment.
LGTM outside of a small nit to apply.
We already have test coverage for this via ProblemDetailsFactoryTest.
Thanks for the first look @gfoidl!
src/Mvc/Mvc.Core/src/Infrastructure/DefaultProblemDetailsFactory.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Safia Abdalla <safia@safia.rocks>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #53030
Following this suggestion i changed the DefaultProblemDetailsFactory class access modifier from internal to public.