Skip to content
This repository has been archived by the owner on Feb 25, 2021. It is now read-only.

Commit

Permalink
Merge pull request #1967 from dotnet/mkArtakMSFT-patch-1
Browse files Browse the repository at this point in the history
Added details about how to run certain steps
  • Loading branch information
mkArtakMSFT committed Jan 17, 2020
2 parents 84d82f6 + 7869c51 commit dd7fb4d
Showing 1 changed file with 14 additions and 3 deletions.
17 changes: 14 additions & 3 deletions src/Microsoft.AspNetCore.Blazor.Mono/HowToUpgradeMono.md
Expand Up @@ -11,6 +11,7 @@
1. Now on the sidebar, navigate to *Azure Artifacts*.

1. Download the .zip file. Note that the commit's SHA hash is in the filename - you'll need that later to track which Mono version we're using in Blazor.
**NOTE**: The Jenkins UI may show some errors when opening a specific build. The `Shortcut` below is most probably still accessible, so move forward with it.

**Shortcut:** Browse directly to https://jenkins.mono-project.com/job/test-mono-mainline-wasm/255/label=ubuntu-1804-amd64/Azure/, replacing the number 255 with the desired build number.

Expand Down Expand Up @@ -43,11 +44,21 @@ At this stage, make a Git commit with a message similar to `Upgrade Mono binarie

Push your change as a PR to the `blazor` repo. Once the CI system has built the resulting package, download it. It usually has a name like `Microsoft.AspNetCore.Blazor.Mono.3.2.0-ci.nupkg`.

Switch over to the `aspnetcore` repo and modify the `eng\Versions.props` file to use your new version (e.g., `3.2.0-ci`). To restore this correctly,

Switch over to the `aspnetcore` repo and modify the `eng\Versions.props` file to use your new version (e.g., `3.2.0-ci`). Locate the `MicrosoftAspNetCoreBlazorMonoPackageVersion` property and update the version to the desired version:
```<MicrosoftAspNetCoreBlazorMonoPackageVersion>3.2.0-CI</MicrosoftAspNetCoreBlazorMonoPackageVersion>```

To restore this correctly:

* Make sure you don't already have a `-ci` version of that package in your NuGet package cache
* Run a `dotnet restore` with `-s <directory_containing_the_download>`

Now try running the StandaloneApp and perf benchmarks to be sure the apps still work, and the size and perf numbers haven't regressed badly. Ideally, also run all the E2E tests.
Now try running the StandaloneApp and perf benchmarks to be sure the apps still work, and the size and perf numbers haven't regressed badly.

After running the above checks, also run all the E2E tests:
- switch to the `src\Components\test\E2ETest`
- run `yarn install` to install the necessary packages (selenium, chrome debug adapter, ...)
- if you don't have installed Java yet, do so
- run `dotnet test` from the Command Line. Alternatively, you can open the solution file from this directory and run the tests from within VS.


If everything looks good, you can proceed with merging your PR to the `blazor` repo.

0 comments on commit dd7fb4d

Please sign in to comment.