Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main to release/dev17.11 #17204

Closed
wants to merge 2 commits into from

Conversation

dotnet-bot
Copy link
Contributor

This is an automatically generated pull request from main into release/dev17.11.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout -t upstream/merges/main-to-release/dev17.11
git reset --hard upstream/release/dev17.11
git merge upstream/main
# Fix merge conflicts
git commit
git push upstream merges/main-to-release/dev17.11 --force

vzarytovskii and others added 2 commits May 21, 2024 10:15
* Enforce `AttributeTargets.Interface`

* Update AllowNullLiteralAttribute AttributeTargets

* Convert to AbstractClass

* release notes

* Comment out IVsMicrosoftInstalledProduct for now

---------

Co-authored-by: Petr <psfinaki@users.noreply.github.com>
Copy link
Contributor

Caution

Repository is on lockdown for maintenance, all merges are on hold.

Copy link
Contributor

❗ Release notes required

@dotnet-bot,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
vsintegration/src docs/release-notes/.VisualStudio/17.11.md No release notes found or release notes format is not correct

✅ Found changes and release notes in following paths:

Warning

No PR link found in some release notes, please consider adding it.

Change path Release notes path Description
src/FSharp.Core docs/release-notes/.FSharp.Core/8.0.400.md No current pull request URL (#17204) found, please consider adding it
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.400.md No current pull request URL (#17204) found, please consider adding it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants