Remove implicit reference to Maui Compatibility and template references #22203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhouts
added
the
area-templates
PureWeen
changed the title
mattleibow
approved these changes
May 3, 2024
davidortinau
previously approved these changes
May 13, 2024
There was a problem hiding this comment.
When I had tried this previously, the package was always referenced no matter what I did with UseMauiCompat. My expectation is that with these changes, unless the package is directly referenced or UseMauiCompat is explicitly true, then the package will not be included. If I'm reading it correctly, that seems to be the case. Correct?
|
That is correct. After this PR, if you are not adding the package or setting the property, then the compat package should not be included. |
mattleibow
previously approved these changes
May 14, 2024
Eilon
requested changes
May 14, 2024
|
/rebase |
github-actions
bot
force-pushed
the
remove_explicit_compat_package
branch
from
c4541fd
to
479d8a6
Compare
Eilon
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
For new users it's not advantageous (and can be confusing) to have the Maui Compatibility package referenced. Nothing from this package should be used by new projects.
TODO
What updates need to be made to the migration tool? Does it already set UseMauiCompat to true?