[iOS] Span's TapGestureRecognizer not working if text is truncated #22213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
May 7, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
May 14, 2024
| @@ -184,7 +184,7 @@ internal static void RecalculateSpanPositions(this UILabel control, Label elemen | |||
| var yaxis = startRect.Top; | |||
| var lineHeights = new List<double>(); | |||
|
|
|||
| while ((endRect.Bottom - yaxis) > 0.001) | |||
| while ((Math.Max(endRect.Bottom, finalSize.Bottom) - yaxis) > 0.001) | |||
There was a problem hiding this comment.
The existing InitialFormattedTextMatchesText test is failing on macOS. Could you try the changes on Catalyst?
System.OutOfMemoryException : Out of memory
at System.Collections.Generic.List`1[[System.Double, System.Private.CoreLib, Version=8.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].set_Capacity(Int32 value)
at System.Collections.Generic.List`1[[System.Double, System.Private.CoreLib, Version=8.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].Grow(Int32 capacity)
at System.Collections.Generic.List`1[[System.Double, System.Private.CoreLib, Version=8.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].AddWithResize(Double item)
at Microsoft.Maui.Controls.Platform.FormattedStringExtensions.RecalculateSpanPositions(UILabel control, Label element) in /Users/builder/azdo/_work/2/s/src/Controls/src/Core/Platform/iOS/Extensions/FormattedStringExtensions.cs:line 202
at Microsoft.Maui.Controls.Label.RecalculateSpanPositions() in /Users/builder/azdo/_work/2/s/src/Controls/src/Core/Label/Label.iOS.cs:line 61
at Microsoft.Maui.Controls.Label.ArrangeOverride(Rect bounds) in /Users/builder/azdo/_work/2/s/src/Controls/src/Core/Label/Label.iOS.cs:line 15
at Microsoft.Maui.Controls.VisualElement.Microsoft.Maui.IView.Arrange(Rect bounds) in /Users/builder/azdo/_work/2/s/src/Controls/src/Core/VisualElement/VisualElement.cs:line 1834
at Microsoft.Maui.DeviceTests.HandlerTestBasement.InitializeViewHandler(IElement element, IElementHandler handler, IMauiContext mauiContext) in /Users/builder/azdo/_work/2/s/src/Core/tests/DeviceTests.Shared/HandlerTests/HandlerTestBasement.cs:line 136
at Microsoft.Maui.DeviceTests.HandlerTestBasement.CreateHandler[LabelHandler,LabelHandler](IElement element, IMauiContext mauiContext) in /Users/builder/azdo/_work/2/s/src/Core/tests/DeviceTests.Shared/HandlerTests/HandlerTestBasement.cs:line 166
at Microsoft.Maui.DeviceTests.HandlerTestBasement.CreateHandler[LabelHandler](IElement view, IMauiContext mauiContext) in /Users/builder/azdo/_work/2/s/src/Core/tests/DeviceTests.Shared/HandlerTests/HandlerTestBasement.cs:line 90
at Microsoft.Maui.DeviceTests.ControlsHandlerTestBase.CreateHandler[LabelHandler](IElement view) in /Users/builder/azdo/_work/2/s/src/Controls/tests/DeviceTests/ControlsHandlerTestBase.cs:line 44
at Microsoft.Maui.DeviceTests.LabelTests.<>c__DisplayClass17_0.<<InitialFormattedTextMatchesText>b__0>d.MoveNext() in /Users/builder/azdo/_work/2/s/src/Controls/tests/DeviceTests/Elements/Label/LabelTests.cs:line 472
--- End of stack trace from previous location ---
at Microsoft.Maui.Dispatching.DispatcherExtensions.<>c__DisplayClass3_0.<<DispatchAsync>b__0>d.MoveNext() in /Users/builder/azdo/_work/2/s/src/Core/src/Dispatching/DispatcherExtensions.cs:line 88
--- End of stack trace from previous location ---
at Microsoft.Maui.Dispatching.DispatcherExtensions.<>c__DisplayClass2_0`1.<<DispatchAsync>b__0>d[[System.Boolean, System.Private.CoreLib, Version=8.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].MoveNext() in /Users/builder/azdo/_work/2/s/src/Core/src/Dispatching/DispatcherExtensions.cs:line 67
--- End of stack trace from previous location ---
at Microsoft.Maui.DeviceTests.LabelTests.InitialFormattedTextMatchesText(Double fontSize) in /Users/builder/azdo/_work/2/s/src/Controls/tests/DeviceTests/Elements/Label/LabelTests.cs:line 470
--- End of stack trace from previous location ---
There was a problem hiding this comment.
@jsuarezruiz it should work now
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Windows is not working either, but I have no machine to work on it
Fixes #21837
Screen.Recording.2024-05-05.at.20.33.23.mov
Screen.Recording.2024-05-05.at.20.31.50.mov